git.y1.nz

commit 8e1e889ce02526a164233aebc7edb7f42743a9dc
parent aa421258b846273b4e21a9858daa06a51c5a55d7
Author: Lior Halphon <LIJI32@gmail.com>
Date:   Sat, 16 Jan 2021 15:31:09 +0200

Add a TODO

Diffstat:
M
Core/apu.c
6
++++++

1 file changed, 6 insertions(+), 0 deletions(-)
diff --git a/Core/apu.c b/Core/apu.c
@@ -712,6 +712,12 @@ uint8_t GB_apu_read(GB_gameboy_t *gb, uint8_t reg)
 
 static inline uint16_t effective_channel4_counter(GB_gameboy_t *gb)
 {
+    /*
+       TODO: On revisions  older than the CGB-D,  this behaves differently  when
+             the counter advanced this exact T-cycle.  Also, in these revisions,
+             it seems that "passive" changes (due to the temporary FF value NR43
+             has during writes) behave slightly different from non-passive ones.
+    */
     uint16_t effective_counter = gb->apu.noise_channel.counter;
     /* Ladies and gentlemen, I present you the holy grail glitch of revision detection! */
     switch (gb->model) {

This webpage is intended to be an accessible preview of this repository. To get a fuller picture, clone it and use the git CLI.