git.y1.nz

commit b4709fd66bd986a5c32b423b317e74ab7a96470d
parent 339613263c79716bff6e8d4dd6f1bb0ca3680733
Author: Lior Halphon <LIJI32@gmail.com>
Date:   Fri, 18 Jun 2021 01:36:29 +0300

Disabled an accuracy-improvement-attempt that caused audio regressions until the proper behavior is well understood, fixes #390

Diffstat:
M
Core/sm83_cpu.c
5
++++-

1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/Core/sm83_cpu.c b/Core/sm83_cpu.c
@@ -288,7 +288,10 @@ static void cycle_write(GB_gameboy_t *gb, uint16_t addr, uint8_t value)
                     gb->apu.square_sweep_calculate_countdown -= 2;
                 }
                 gb->apu.enable_zombie_calculate_stepping = true;
-                GB_write_memory(gb, addr, 0xFF);
+                /* TODO: this causes audio regressions in the Donkey Kong Land series.
+                   The exact behavior of this quirk should be further investigated, as it seems
+                   more complicated than a single FF pseudo-write. */
+                // GB_write_memory(gb, addr, 0xFF);
             }
             GB_write_memory(gb, addr, value);
             gb->pending_cycles = 4;

This webpage is intended to be an accessible preview of this repository. To get a fuller picture, clone it and use the git CLI.