git.y1.nz

commit 00e8bbdf135b5cad8e21dfdfd93a9dc4789d36db
parent 616ef9e9c22cbb04b412529523cf2c0577228203
Author: bbbbbr <bbbbbr@users.noreply.github.com>
Date:   Fri,  2 May 2025 11:38:20 -0700

Merge pull request #769 from bbbbbr/bankpack/arraysize_bug

Bankpack: Fix incorrect array growth size
Diffstat:
M
docs/ChangeLog
4
+++-
M
docs/pages/10_release_notes.md
3
++-
M
gbdk-support/bankpack/list.c
2
+-
M
gbdk-support/makecom/list.c
2
+-
M
gbdk-support/romusage/src/list.c
2
+-

5 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/docs/ChangeLog b/docs/ChangeLog
@@ -26,7 +26,9 @@ gbdk-4.4.0
         - Added -area option to specify linker area name (such as -area LIT for SMS/GG)
         - Added support for 512 tiles via alternate tile bank on GBC
         - Fixed Palette Generation broken when using -source_tileset option
-      - bankpack: Added support for MBC7
+      - bankpack:
+        - Added support for MBC7
+        - Fixed out of memory bug with large number of object files      
       - romusage
         - Added Set hex bytes treated as Empty in ROM files (.gb/etc) -b:HEXVAL:[...]
         - Added option to Hide memory regions (ex hide all RAM: -nMEM:RAM)
diff --git a/docs/pages/10_release_notes.md b/docs/pages/10_release_notes.md
@@ -6,7 +6,7 @@ https://github.com/gbdk-2020/gbdk-2020/releases
 
 # GBDK-2020 Release Notes
 
-## GBDK-2020 4.3.0
+## GBDK-2020 4.4.0
   2025/...
   - Includes SDCC version ~4.5.0 (15267) with GBDK-2020 patches for Z80 and NES
     - [Patched SDCC Builds](https://github.com/gbdk-2020/gbdk-2020-sdcc/releases) with support for Sega GG/SMS and the Nintendo NES are used.
@@ -53,6 +53,7 @@ https://github.com/gbdk-2020/gbdk-2020/releases
       - Fixed Palette Generation broken when using `-source_tileset` option
     - @ref bankpack
       - Added support for MBC7
+      - Fixed out of memory bug with large number of object files
     - @ref utility_romusage "romusage"
       - Added Set hex bytes treated as Empty in ROM files (.gb/etc) `-b:HEXVAL:[...]`
       - Added option to Hide memory regions (ex hide all RAM: `-nMEM:RAM`)
diff --git a/gbdk-support/bankpack/list.c b/gbdk-support/bankpack/list.c
@@ -48,7 +48,7 @@ void list_additem(list_type * p_list, void * p_newitem) {
         // Save a copy in case reallocation fails
         tmp_list = p_list->p_array;
 
-        p_list->size += p_list->typesize * LIST_GROW_SIZE;
+        p_list->size += LIST_GROW_SIZE;
         p_list->p_array = (void *)realloc(p_list->p_array, p_list->size * p_list->typesize);
         // If realloc failed, free original buffer before quitting
         if (!p_list->p_array) {
diff --git a/gbdk-support/makecom/list.c b/gbdk-support/makecom/list.c
@@ -49,7 +49,7 @@ void list_additem(list_type * p_list, void * p_newitem) {
         // Save a copy in case reallocation fails
         tmp_list = p_list->p_array;
 
-        p_list->size += p_list->typesize * LIST_GROW_SIZE;
+        p_list->size += LIST_GROW_SIZE;
         p_list->p_array = (void *)realloc(p_list->p_array, p_list->size * p_list->typesize);
         // If realloc failed, free original buffer before quitting
         if (!p_list->p_array) {
diff --git a/gbdk-support/romusage/src/list.c b/gbdk-support/romusage/src/list.c
@@ -50,7 +50,7 @@ void list_additem(list_type * p_list, void * p_newitem) {
         // Save a copy in case reallocation fails
         tmp_list = p_list->p_array;
 
-        p_list->size += p_list->typesize * LIST_GROW_SIZE;
+        p_list->size += LIST_GROW_SIZE;
         p_list->p_array = (void *)realloc(p_list->p_array, p_list->size * p_list->typesize);
         // If realloc failed, free original buffer before quitting
         if (!p_list->p_array) {

This webpage is intended to be an accessible preview of this repository. To get a fuller picture, clone it and use the git CLI.