git.y1.nz

commit 753bed93cf954191a60a1769fbc330e238022d38
parent 2f4f9e6dc6ee253876263dbe5704fd76f2da0455
Author: Toxa <untoxa@mail.ru>
Date:   Tue, 23 Nov 2021 18:19:31 +0300

examples: set_interrupts() disables/enables interrupts so it must be outside of critical section

Diffstat:
M
gbdk-lib/examples/ap/comm/comm.c
2
+-
M
gbdk-lib/examples/ap/scroller/text_scroller.c
2
+-
M
gbdk-lib/examples/gb/comm/comm.c
2
+-
M
gbdk-lib/examples/gb/scroller/text_scroller.c
2
+-

4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/gbdk-lib/examples/ap/comm/comm.c b/gbdk-lib/examples/ap/comm/comm.c
@@ -19,8 +19,8 @@ void main(void)
 
     CRITICAL {
         add_SIO(nowait_int_handler);    // disable waiting VRAM state before return
-        set_interrupts(SIO_IFLAG);      // disable other interrupts
     }
+    set_interrupts(SIO_IFLAG);          // disable other interrupts. note: this disables sprite movement
 
     while(1) {
         i = waitpad(J_A | J_B | J_START | J_SELECT);
diff --git a/gbdk-lib/examples/ap/scroller/text_scroller.c b/gbdk-lib/examples/ap/scroller/text_scroller.c
@@ -44,8 +44,8 @@ void main() {
     CRITICAL {
         STAT_REG |= STATF_LYC; LYC_REG = 0;
         add_LCD(scanline_isr);
-        set_interrupts(VBL_IFLAG | LCD_IFLAG);
     }
+    set_interrupts(VBL_IFLAG | LCD_IFLAG);
 
     scroller_vram_addr = get_bkg_xy_addr(20, SCROLL_POS);
     set_vram_byte(scroller_vram_addr, *scroller_next_char - 0x20);
diff --git a/gbdk-lib/examples/gb/comm/comm.c b/gbdk-lib/examples/gb/comm/comm.c
@@ -19,8 +19,8 @@ void main(void)
 
     CRITICAL {
         add_SIO(nowait_int_handler);    // disable waiting VRAM state before return
-        set_interrupts(SIO_IFLAG);      // disable other interrupts
     }
+    set_interrupts(SIO_IFLAG);          // disable other interrupts. note: this disables sprite movement
 
     while(1) {
         i = waitpad(J_A | J_B | J_START | J_SELECT);
diff --git a/gbdk-lib/examples/gb/scroller/text_scroller.c b/gbdk-lib/examples/gb/scroller/text_scroller.c
@@ -44,8 +44,8 @@ void main() {
     CRITICAL {
         STAT_REG |= STATF_LYC; LYC_REG = 0;
         add_LCD(scanline_isr);
-        set_interrupts(VBL_IFLAG | LCD_IFLAG);
     }
+    set_interrupts(VBL_IFLAG | LCD_IFLAG);
 
     scroller_vram_addr = get_bkg_xy_addr(20, SCROLL_POS);
     set_vram_byte(scroller_vram_addr, *scroller_next_char - 0x20);

This webpage is intended to be an accessible preview of this repository. To get a fuller picture, clone it and use the git CLI.